Mozilla

Highlights

• Lots of performance work going on.
• Scott helped land S/MIME.
• Jean-Francois fixed a number of bugs relating to how we handle and display attachments in the compose window.
  
• Resolved as fixed 58 bugzilla bugs.
  

Performance and Footprint

• Most of the mail team is now going to focus on performance in 0.9.7 and 0.9.8
• Seth created this performance page.
• 3 pane
  • Seth and Cavin worked on reducing the 3 pane toolbar command updating when switching folder. We think this might have up to a 10% gain. Cavin was seeing improvements of up to .25 seconds.
  • Navin is working on increasing Next Folder performance. Many people are noticing a long delay when moving to the next folder.
  • Navin has a fix for speeding up closing a mailbox (PR_Close()) - by opening the mailbox in read-only mode.
  • David fixed toolbar flashing when deleting a message.
• Compose Window
  • Jean-Francois checked in his changes to cache the compose window. It's currently controlled by a hidden pref. He'll soon make an announcement about how to turn it on for testing.
  • Varada is investigating how to integrate the compose window caching effort into turbo.
  • Seth suppressed command updating when possible in the compose window
  • Seth removed an unnecessary command set for the save menu in the compose window.
• Startup Performance
  • Seth made it so we don't persist the open state of news servers which should improve startup performance by not querying newsservers for newsgroup counts.
  • Cavin is continuing to look into startup performance. He's investigating what's happening around the creation of the 3pane Webshells which appear to be responsible for 1/3 of startup time.
    
• Address Book
  • Seth started working on converting the address book to use outliner.
  • Seth cleaned up tree.css in the classic skin and cleaned up and optimized addressPanes.css
• Footprint
  • David is working on removing the orkin layer in Mork, and converting underlying Mork objects to use XPCOM instead of the mork internal ref-counting system. Both of these should make it easier to fix memory leaks in Mork, and make the code more maintainable.
  • Varada met with Chris Mcafee to discuss how to start measuring mailnews leaks/bloat on Tinderbox.

Mailnews Accomplishments

• Seth
  • Started working on converting the address book to use outliner.
  • Created the performance plan page.
  • Cleaned up tree.css in the classic skin and cleaned up and optimized addressPanes.css
  • Made it so we don't persist the open state of news servers which should improve startup performance.
  • Worked with Cavin on reducing the 3 pane toolbar command updating.
  • Suppressed command updating when possible in the compose window
  • Removed an unnecessary command set for the save menu in the compose window.
  • Landed the account manager extension. This will first be used by S/MIME.
  • Implemented sorting and added colors for about:config.
  • Fixed a regression where there was a crash and context menu problems.
  • Fixed a regression where certain imap messages couldn't be displayed
  • Made it so we close the Standalone Window on the final delete
  • Fixed the Ignore Thread mnemonic.
  • Fixed a news crasher.
  • Fixed a crash when downloading news headers.
    
  • Prevented the label column from showing up in search.
  • Made it so we can autosubscribe to a newsgroup when only a browser is open.
  • Made it so that when canceling an autosubscribe dialog you can run the same url again.
• Cavin
  • Made it so that when replying to an IMAP message, we fetch by part so we only get the body, not the attachments.
  • Investigated startup performance.
• Navin
  • Made it so that flag changes in Quick Search show up.
  • Fixed a bug where empty trash was only working when Trash was the selected folder.
  • Investigated a recent slowdown in local folder operations on Windows. It seems like this is happening when opening and closing files.
  • Working on increasing Next Folder performance. Many people are noticing a long delay when moving to the next folder.
  • Has a fix for speeding up closing of mailbox (PR_Close()) - by opening the mailbox in
    read-only mode.
• Scott
  • Finished working on SMIME as an extension to mailnews and landed it on the trunk under a BUILD_SMIME build flag.
• Sean
  • Continued working on Labels
• David
  • Fixed toolbar flashing when deleting a message.
  • Working on removing the orkin layer in Mork, and converting underlying Mork objects to use XPCOM instead of the mork internal ref-counting system. Both of these should make it easier to fix memory leaks in Mork, and make the code more maintainable.
  • Worked with Navin on fixing the emptying of local trash when you hadn't opened the trash or deleted a message in the session.
  • Helped fix the regression reading imap messages with inline images
• Varada
  • Worked on Block Addresses
  • Met with mcafee to get mail tests for leak/bloat on tinderbox (with hope they should land this week).
  • Started work on getting mail compose on turbo for first window perf improvement.
• Bhuvan
  • Worked on a regression where clicking finish in the account wizard crashed.
  • Worked on a regression where mailnews context menus weren't working.
  • Started working on converting the account wizard to the new <wizard/>
• Jean-Francois
  • Checked in changes to make us cache the compose window. It can be turned on with a hidden preference which will soon be announced.
  • Made it so we can determine an attachment's content type based on the filename.
  • Made it so that error messages when saving mail refer to saving, not sending.
  • Fixed a crash when viewing an invalid attached webpage.
  • Made it so we close the progress dialog if an error occurs during a send.
  • Made it so we display the correct error message when copying to sent fails during Send Unsent Messages.
  • Made it so we can associate different information with an attachment such as the content type.
• neil@parkwaycc.co.uk
  • Removed menu class="push" from mailnews folder pickers.
  • Fixed a bug where having a reply-to set could prevent a To: field from showing up in the compose window.
    
• Håkan Waara
  • Made it so that the user gets prompted before adding a newsgroup from a news url.
• caillon@returnzero.com
  • Fixed some js warnings in sendMessage.js
• jg@cyberstorm.demon.co.uk
  • Fixed some js warnings in the address book

• mozilla.org policy on Handling Mozilla Security Bugs version 1.0 published
• Tree is frozen for 0.9.6 If you have changes that should land for 0.9.6 please mail drivers@mozilla.org with a link to the bug, a description of the problem, and the risk associated with your change. We hope to branch as early as this Friday, with a release at the end of next week.
• Mozilla 0.9.4.1 released. This is a source only release consisting of the open source code from which the recent Netscape 6.2 release was built.
• Bug Week attracted many people and seemed to go very well. Too early to tell what the long term effect is.
• Final preparations for Developer Day underway

Editor status for week ending 09-nov-2001

• Akkana (Composer Team)
  • Have fix ready to check in for bug 104195 (rewrap destroys quotes).
  • Made a minor change to bug 91388 (link checker) to go along with an apparent recent change in xpconnect -- ready to check in.
  • Found a fix for bug 50131, pass filename arguments on launch.  Looking for review.
• Kin (Layout team)
  • Lots-o-code reviews/superreviews due to 0.9.6 closure.
  • Checked in fixes for:
    • bug 99517 (Text migrates past H. Line, loses formatting when converted to list)
    • bug 101599 (onChange fires when hitting return in text widgets)
    • bug 106383 (regression: new composer doc behaves as if empty)
  • Have fix for bug 96455 (hr has duplicate lineboxes in frame tree )
  • Currently trying to figure out why GetPrimaryFrame() returns the wrong frame for BRs that have pseudo content.
  • Spent quite a bit of time looking into the following bugs, only to find that they were due to bug 74383 (nsBoxToBlockAdaptor::Reflow() prevents TextArea contents from being reflowed), which everyone was having problems recreating. I came up with a reliable test case and reopened the bug. This really needs to get fixed!
    • bug 100727 (Javascript to modify textarea causes field to go blank/unchanged)
    • bug 101122 (Textarea sometimes not refreshing correctly (blank space after delete sel., etc.))
    • bug 107973 (Cut and paste in forms is broken)
  • Did some preliminary debugging on several editor bugs.
  • Attended Editor Cross-Functional Mtg, Layout Tech Mtg on XBL and Form Widgets, and Performance Tools Brown Bag.
• Kathy (Composer Team)
  • Recovered development Mac by reinstalling OS and 2 system upgrades (all day Thursday)
  • Found workaround for blocker Mac bug on OS8.6 (and 8.5?)
  • Almost done with JS port of save stuff (moving out of editorshell); still testing
    
  • Code Reviews
  • Feedback on editor preferences (which are used or may be used and which are dead)
• Daniel (Layout team)
  • spent time again on the sheetMap table in the CSSLoader and would like to thank Boris Bzarsky for giving us the hint that allowed to understand its purpose. The sheetMap is indeed useful but we discovered that it is not ready at all for dynamic manipulation of the stylesheets attached to a document. There are a bunch of real-life cases where this manipulation is needed. Looking into it with the help of others : peterv, sicking, bz.
  • various code reviews including long Boris's fix for computed style
    
  • prepared a comment-only patch for CSSLoader : explain what is the sheetMap !
  • started looking at String usage in the CSS parser
    
  • worked on the assignment of CSS classes to the selection in Composer
    • retrieve the list of class and ID selectors contained in all stylesheets attached to the edited document
    • extend the paragraph format pulldown to view those selectors' names
    • extend SetInlineProperty to assign a class to the selection ; the assignment of an ID is different : other occurence(s) of the ID in the document must be removed.
• Charley (Composer Team)
  • 0.9.6 bugs fixed and checked in:
  • 106728 "New" command not working from Composer window
  • 108670 Cleanup from more XUL 1.0 syntax changes
  • 10888 (Bugscape) Fixed layout problems for Spell Check and Image dialogs (also XUL fallout).
  • 109085 Fixed Advanced Edit dialog.
    
  • Reviewed Brade's Save File rewrite. Reviewed 3 other bug fixes.
  • Reviewed Composer prefs, even though Brade had already beat me to it!
  • Had to push off a couple of 0.9.6 bugs because of XUL side effect repairs.

Plans

• Akkana
  • Check in pending fixes if tree opens.
  • Get my new machine to a state where it can build the lizard.
  • Work on publishing/saving APIs.
• Kin
  • Triage Editor:Core untargeted bugs.
  • Continue working on 0.9.6 bugs.
  • Finish up glazman's CSS Composer code review.
• Kathy
  • Monday off
  • Finish JS port of save stuff
  • Check in a fix for double-typing bug on MacOS8.6 for 0.9.6
    
  • Code reviews
• Charley
  • Continue on Publish UI and 0.9.7 bug fixing.

Problems

• The effects of XUL changes are getting more annoying. E.g., our colorpicker swatches on the toolbar no longer work because only "buttons" can trigger onclick/oncommand handlers.
• Akkana
  • It's been over a week since we've had a usable build.  I'm back to using 4.x for my browsing, for the first time in a year or so.  Every day has had multiple new blockers.  What's going on, and can we make it better?
• Kathy
  • concern about untriaged bugs in Editor : Composer component (over 60 with no milestone)
  • unstable, buggy builds

Highlights

• Got calendar into Mozilla's CVS tree.
• bryner made up some build scripts so the calendar now builds (Linux only). MOZ_CALENDAR=1 environment variable enabled for building the calendar. Updated the calendar project website (http://www.mozilla.org/projects/calendar) with the latest build instructions.
• Began work on a requirements document.
• Fixed many XUL problems so the calendar now runs on the tip of the trunk.
• Calendar component added to bugzilla, so bugs can now be added for calendar.

Lowlights

• Found a XUL bug with decks that required case sensitive attribute.
• Filed bug 109880.

Next week

• Continue to work on a requirements document and a roadmap document for the calendar project as a whole.

Previous Updates