General Notes
This document covers all patches to the mozilla/browser hierarchy. For questions or concerns arising from this document, please direct questions to the dev-planning mailing list/newsgroup.
Review Rules
- Wherever possible, significant patches in a certain area should be reviewed by one of the listed sub-module owner/reviewers.
- Peers may grant review in any area, provided they feel confident in their knowledge of the code being changed.
- One review is sufficient in most cases. If the first reviewer feels that the patch would benefit from additional reviews, they should request a second review from an appropriate person.
- Members may only grant review in areas they are listed as reviewers.
- Significant user interface & experience changes should get ui-review from someone in the UI group, along with code review.
Unit-Test Rules
- All patches must include unit tests which are run during make check. Once unit tests are committed, the in-testsuite+ flag should be set on the bug.
- Unit tests must be included in patches and reviewed just like any other code.
- If running the test during make check is not possible, consult with Robert Sayre (sayrer) to determine whether another test system is available.
- If a unit test framework is needed but is not yet available, the developer should write appropriate test code and commit it. A bug should be filed on the needed test framework. The in-testsuite? flag should be set on the bug until the framework has been completed and the test code is running automatically.
- Certain build-config or tooling bugs which don't affect the actual product cannot be usefully tested. Additionally, there are many trivial and obvious fixes (typos, theme CSS changes, etc) that fall into this category. These bugs should have the in-testsuite- flag set.
Individuals and Roles
| Module Owner | Mike Connor |
|---|---|
| UI Group | Mike Beltzner, Mike Connor |
| Peers | Asaf Romano, Gavin Sharp, Seth Spitzer, Vladimir Vukicevic |
| Members | Dietrich Ayala, Simon Bünzli, Tony Chang, Myk Melez, Robert Sayre, Benjamin Smedberg, Robert Strong |
Due to the large and diverse nature of code included in the browser module, we have divided responsibilities by sub-module, in order to spread the load appropriately and effectively. The owner or a peer may review patches anywhere in the mozilla/browser hierarchy, provided they feel confident in their knowledge of the area in question.
| Sub-Module | Code covered | Owner | Other Reviewers |
|---|---|---|---|
| General UI bits | browser/base/content, browser/components (for those not covered elsewhere) |
Mike Connor | Asaf Romano, Gavin Sharp, Seth Spitzer |
| Build & Startup bits | browser/app browser/components/nsBrowserContentHandler.js |
Benjamin Smedberg | Mike Connor, Asaf Romano, Gavin Sharp |
| Profile Migrators | browser/components/migration | Gavin Sharp | Mike Connor, Asaf Romano |
| Shell Service | browser/components/shell | Asaf Romano | Mike Connor, Gavin Sharp, Robert Strong |
| Preferences Window | browser/components/preferences | Mike Connor | Asaf Romano, Gavin Sharp |
| Places | browser/components/places and places-related code in browser/base/content |
Dietrich Ayala | Seth Spitzer, Asaf Romano, Robert Sayre |
| Search | browser/components/search | Gavin Sharp | Mike Connor, Asaf Romano |
| Feed Preview | browser/components/feeds | Asaf Romano | Gavin Sharp, Robert Sayre |
| Microsummaries | browser/components/microsummaries | Myk Melez | Asaf Romano, Gavin Sharp |
| Session Restore | browser/components/sessionstore | Dietrich Ayala | Simon Bünzli, Asaf Romano, Gavin Sharp |
| Safe Browsing | browser/components/safebrowsing | Tony Chang | Gavin Sharp |
| Installer | browser/installer | Robert Strong | Benjamin Smedberg, Seth Spitzer |